Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor iterative labeling logic init from discs only #54

Closed
wants to merge 3 commits into from

Conversation

yw7
Copy link
Collaborator

@yw7 yw7 commented Sep 12, 2024

Reorganized the spine labeling logic by separating the functionality into distinct functions for better readability and maintainability. Removed init_vertebrae, step_diff_label, step_diff_disc, and related parameters to streamline the process. Added new parameters output_c2c3 and output_c2 for setting specific output labels.

This refactor facilitates easier adjustments and enhancements in the future, improving code usability.

Resolves issue #50

Reorganized the spine labeling logic by separating the functionality into distinct functions for better readability and maintainability. Removed `init_vertebrae`, `step_diff_label`, `step_diff_disc`, and related parameters to streamline the process. Added new parameters `output_c2c3` and `output_c2` for setting specific output labels.

This refactor facilitates easier adjustments and enhancements in the future, improving code usability.

Resolves issue #50
@yw7 yw7 linked an issue Sep 12, 2024 that may be closed by this pull request
@yw7 yw7 self-assigned this Sep 12, 2024
@yw7 yw7 added the enhancement New feature or request label Sep 12, 2024
@yw7 yw7 requested a review from NathanMolinier September 12, 2024 13:52
@NathanMolinier
Copy link
Collaborator

This PR will be used to improve the accuracy of the labeling aswell. See #45

yw7 added 2 commits September 12, 2024 22:31
Renamed variables and comments to improve clarity and understandability of the labeling process. Adjusted label computation logic to accurately reflect the sorting and labeling operations, especially for handling cases involving C1 and C2 vertebrae. This enhances readability and maintains consistency within the code base.

No functional changes are expected.
Refined the logic for determining the superior output label by replacing the use of the first element with the most frequent element. This ensures better accuracy in cases with multiple segmented labels and improves robustness in varying data scenarios.

Addresses potential inaccuracies in segmentation outputs noted during recent evaluations.
@yw7 yw7 closed this Sep 16, 2024
@yw7 yw7 deleted the init-discs-only branch September 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants