Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyside6 #11

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Switch to pyside6 #11

merged 3 commits into from
Dec 12, 2024

Conversation

AndreiSavici
Copy link
Member

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (2eb2dea) to head (1762851).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #11      +/-   ##
==========================================
- Coverage   90.50%   90.19%   -0.32%     
==========================================
  Files           8        8              
  Lines         158      153       -5     
==========================================
- Hits          143      138       -5     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreiSavici AndreiSavici enabled auto-merge (squash) December 12, 2024 16:28
@KyleQianliMa KyleQianliMa self-requested a review December 12, 2024 16:30
Copy link
Collaborator

@KyleQianliMa KyleQianliMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes. Tested locally nothing wrong popped up.

@AndreiSavici AndreiSavici merged commit ad7de6e into next Dec 12, 2024
3 checks passed
@AndreiSavici AndreiSavici deleted the switch2pyside6 branch December 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants