Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Create task log callback map #85

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix: Create task log callback map #85

merged 3 commits into from
Dec 3, 2024

Conversation

clriesco
Copy link
Contributor

@clriesco clriesco commented Dec 3, 2024 •
edited
Loading

Description

  • Removed .on('_connect') handler when adding callback handlers to task log.
  • Added callback map (one callback for each task id, if it is needed)
  • Removed callbacks once task is completed or failed.

Is this PR related with an open issue?

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@clriesco clriesco requested review from a team as code owners December 3, 2024 09:09
@clriesco clriesco self-assigned this Dec 3, 2024
@clriesco clriesco added the bug Something isn't working label Dec 3, 2024
@clriesco clriesco merged commit 04ecd6b into main Dec 3, 2024
2 checks passed
@clriesco clriesco deleted the fix/task-log-socket branch December 3, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees

@clriesco clriesco

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clriesco @aaitor