chore: cleanup

integration/external/Services_NFT1155.e2e.test.ts

@@ -257,6 +257,8 @@ describe('Gate-keeping of Web Services using NFT ERC-1155 End-to-End', () => {
               tokenId: subscriptionDDO.shortId(),
               duration: 0, // Doesnt expire
               amount: costServiceInCredits, // The cost of accessing the service
+              maxCreditsToCharge: 2n,
+              minCreditsToCharge: 1n,
               nftTransfer,
             },
           },
@@ -537,6 +539,7 @@ describe('Gate-keeping of Web Services using NFT ERC-1155 End-to-End', () => {
     it('should be able to retrieve services associated with a subscription filtering by endpoints', async () => {
       const result = await nevermined.search.servicesBySubscription(
         subscriptionDDO.id,
+        NeverminedNFT1155Type.nft1155Credit,
         endpointsFilter,
       )
       assert.equal(result.totalResults.value, 1)
@@ -553,6 +556,7 @@ describe('Gate-keeping of Web Services using NFT ERC-1155 End-to-End', () => {
     it('should not be able to retrieve any services associated with a subscription filtering by endpoints which do not exist', async () => {
       const result = await nevermined.search.servicesBySubscription(
         subscriptionDDO.id,
+        NeverminedNFT1155Type.nft1155Credit,
         endpointsFilter2,
       )
       assert.equal(result.totalResults.value, 0)

src/keeper/contracts/templates/NFTAccessTemplate.ts

@@ -173,10 +173,6 @@ export class NFTAccessTemplate extends BaseTemplate<NFTAccessTemplateParams, Ser
       nftAccessService.attributes.main.nftAttributes,
     )
 
-    console.log(`Track :: NFT Tokens to burn: ${amount}`)
-    console.log(JSON.stringify(nftAccessService.attributes.main.nftAttributes))
-    console.log(params)
-
     const contractAddress = DDO.getNftContractAddressFromService(nftAccessService)
 
     const tokenId = DDO.getTokenIdFromService(nftAccessService) || ddo.id

src/models/NFTAttributes.ts

@@ -78,12 +78,8 @@ export class NFTServiceAttributes {
 
     if (dynamicAmount !== undefined) {
       if (dynamicAmount > nftAttributes.maxCreditsToCharge) {
-        // TODO: Evaluate if thow an exception or return the max credits that can be charged
-        //throw new DynamicCreditsOverLimit(`The amount of credits to consume ${dynamicAmount} is higher than the max credits charged ${this.maxCreditsToCharge}`)
         return nftAttributes.maxCreditsToCharge
       } else if (dynamicAmount < nftAttributes.minCreditsToCharge) {
-        // TODO: Evaluate if thow an exception or return the min amount to be charged
-        //throw new DynamicCreditsUnderLimit(`The amount of credits to consume ${dynamicAmount} is lower than the min credits charged ${this.minCreditsToCharge}`)
         nftAttributes.minCreditsToCharge
       }
       return dynamicAmount