Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/arbitrum fees #577

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Fix/arbitrum fees #577

merged 5 commits into from
Sep 14, 2023

Conversation

r-marques
Copy link
Member

Description

Turns out that arbitrum uses an EIP-1559 style transactions but since transactions are processed in a first come first served basis adding a priority tip to the miners makes no sense. In the end reverting back to setting only gasPrice in the transactions (non EIP-1559 style) was what solved the issue.

This was tested on arbitrum-one, here is a comparison of the fees:

metamask $0.24 0.00014701ETH

before sdk fix $3.64 0.00227846ETH
after sdk fix $0.32 0.00019846ETH

Is this PR related with an open issue?

Closes #404

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@r-marques r-marques marked this pull request as ready for review September 13, 2023 11:17
@r-marques r-marques requested review from a team as code owners September 13, 2023 11:17
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r-marques r-marques merged commit 3e5d227 into main Sep 14, 2023
@r-marques r-marques deleted the fix/arbitrum-fees branch September 14, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 3rd party fee calculator
2 participants