Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/node 18 #580

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Feat/node 18 #580

merged 6 commits into from
Sep 28, 2023

Conversation

r-marques
Copy link
Member

Description

  • CI should test against node 18
  • Remove support for node 16

Is this PR related with an open issue?

Closes #579

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@r-marques r-marques requested review from a team as code owners September 21, 2023 10:07
@r-marques r-marques changed the base branch from main to develop September 21, 2023 10:09
@r-marques r-marques merged commit 925292e into develop Sep 28, 2023
3 checks passed
@r-marques r-marques deleted the feat/node-18 branch September 28, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eruizgar91 eruizgar91 eruizgar91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support node 18+
2 participants
@r-marques @eruizgar91