Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search by subscription needs to filter by tokenId #598

Merged
merged 4 commits into from
Oct 19, 2023
Merged

fix: search by subscription needs to filter by tokenId #598

merged 4 commits into from
Oct 19, 2023

Conversation

eruizgar91
Copy link
Member

Description

Fix queries by subscription, because need to filter by tokenID

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@eruizgar91 eruizgar91 requested review from a team as code owners October 19, 2023 09:31
aaitor
aaitor approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small improvement in the ercType

src/nevermined/api/SearchApi.ts Outdated Show resolved Hide resolved
src/nevermined/api/SearchApi.ts Outdated Show resolved Hide resolved
@eruizgar91 eruizgar91 merged commit 93adf6e into develop Oct 19, 2023
3 checks passed
@eruizgar91 eruizgar91 deleted the fix/queries-by-subscription branch October 19, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eruizgar91 @aaitor