Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue where ethers signTypedData was not being called correctly #605

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: issue where ethers signTypedData was not being called correctly #605

merged 1 commit into from
Oct 26, 2023

Conversation

r-marques
Copy link
Member

Description

  • fix issue where the ethers signer was not being called correctly for typed message signatures
  • bump version to 2.0.2
  • added @turnkey/ethers has a dependency to prevent compilation warnings coming from zerodev

Is this PR related with an open issue?

Related to Issue #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@r-marques r-marques requested review from a team as code owners October 26, 2023 12:13
@r-marques r-marques merged commit f55dffd into main Oct 26, 2023
@r-marques r-marques deleted the fix/signTypeMessages-with-ethers branch October 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eruizgar91 eruizgar91 eruizgar91 approved these changes

@aaitor aaitor aaitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-marques @aaitor @eruizgar91