Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update multiverse scanner solution to .NET 8 #2895

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

nr-ahemsath
Copy link
Member

Why not .NET 9? I didn't want to deal with temporarily configuring the CI to install the .NET 9 SDK. Going with an LTS version of .NET and we can bump it to .NET 10 next year.

@nr-ahemsath nr-ahemsath requested a review from a team as a code owner November 20, 2024 18:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.41%. Comparing base (3b1d385) to head (2c8f0fe).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   81.42%   81.41%   -0.01%     
==========================================
  Files         465      465              
  Lines       29563    29563              
  Branches     3278     3278              
==========================================
- Hits        24071    24069       -2     
- Misses       4698     4699       +1     
- Partials      794      795       +1     
Flag Coverage Δ
Agent 82.34% <ø> (-0.01%) ⬇️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

@nr-ahemsath nr-ahemsath merged commit e803d09 into main Nov 20, 2024
96 checks passed
@nr-ahemsath nr-ahemsath deleted the chore/update-multiverse-scanner-dotnet8 branch November 20, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants