Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update module github.com/sap/go-hdb to v1 #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(deps): update module github.com/sap/go-hdb to v1 #487

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 3, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/SAP/go-hdb v0.107.3 -> v1.12.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

SAP/go-hdb (github.com/SAP/go-hdb)

v1.12.5

Compare Source

  • updated documentation

v1.12.4

Compare Source

  • updated dependencies
  • fixed README.me HANA client link

v1.12.3

Compare Source

  • updated dependencies
  • fixed linter issues

v1.12.2

Compare Source

v1.12.1

Compare Source

  • updated dependencies
  • support of additional linter checks

v1.12.0

Compare Source

Minor revisions
v1.12.5
  • updated documentation
v1.12.4
  • updated dependencies
  • fixed README.me HANA client link
v1.12.3
  • updated dependencies
  • fixed linter issues
v1.12.2
v1.12.1
  • updated dependencies
  • support of additional linter checks
Changes
  • Changed 'prometheus' into own go module to reduce dependencies on go-hdb.

v1.11.3

Compare Source

  • fixed bug (panic) in sql trace output in case the sql trace is not switched on
  • updated dependencies

v1.11.2

Compare Source

  • fixed bug in converting integer arguments to HANA boolean type

v1.11.0

Compare Source

Minor revisions
v1.11.3
  • fixed bug (panic) in sql trace output in case the sql trace is not switched on
  • updated dependencies
v1.11.2
  • fixed bug in converting integer arguments to HANA boolean type
v1.11.1
  • fixed linter issues
New features
  • Added bulk insert via iterator (see example) for go versions >= go1.23.0
  • Added net.KeepAliveConfig to connector (TCPKeepAliveConfig)
    and enable on default with default settings for go versions >= go1.23.0
Changes
  • Added support of Go 1.23.
  • Dropped support of Go language versions < Go 1.22.

v1.10.5

Compare Source

v1.10.4

Compare Source

  • fixed bug (panic) in go-hdb/driver/stmt.go function execCall on calling stored procedures with table output parameters without providing arguments (args)

v1.10.3

Compare Source

  • updated dependencies

v1.10.2

Compare Source

  • fixed race condition closing transactions

v1.10.1

Compare Source

  • updated dependencies

v1.10.0

Compare Source

Minor revisions
v1.10.4
  • fixed bug (panic) in go-hdb/driver/stmt.go function execCall on calling stored procedures with table output parameters without providing arguments (args)
v1.10.3
  • updated dependencies
v1.10.2
  • fixed race condition closing transactions
v1.10.1
  • updated dependencies
New features
  • Added user switch on existing connection (see example).

v1.9.11

Compare Source

  • fixed race conditions on cancelled statement calls

v1.9.10

Compare Source

  • updated dependencies
  • avoid race conditions due to lob scans

v1.9.9

Compare Source

  • updated dependencies
  • added go1.23rc1 make

v1.9.8

Compare Source

  • changed go-mod go version back to go1.21

v1.9.7

Compare Source

  • fixed panic calling driver.DB.Close()
  • updated dependencies

v1.9.6

Compare Source

  • updated dependencies

v1.9.5

Compare Source

  • replaced testing hook by context

v1.9.4

Compare Source

  • removed dependency

v1.9.3

Compare Source

  • switching SQL trace on / off including pooled connections

v1.9.2

Compare Source

  • performance improvements
  • fixed race conditions

v1.9.1

Compare Source

  • fixed race conditions on cancelled statement calls

v1.9.0

Compare Source

Minor revisions
v1.9.11
  • fixed race conditions on cancelled statement calls
v1.9.10
  • updated dependencies
  • avoid race conditions due to lob scans
v1.9.9
  • updated dependencies
  • added go1.23rc1 make
v1.9.8
  • changed go-mod go version back to go1.21
v1.9.7
  • fixed panic calling driver.DB.Close()
  • updated dependencies
v1.9.6
  • updated dependencies
v1.9.5
  • replaced testing hook by context
v1.9.4
  • removed dependency
v1.9.3
  • switching SQL trace on / off including pooled connections
v1.9.2
  • performance improvements
  • fixed race conditions
v1.9.1
  • performance improvements
New features
  • Added statement metadata (see example).
  • Improved sql trace.

v1.8.30

Compare Source

  • updated README root certificate sections

v1.8.29

Compare Source

  • updated dependencies

v1.8.28

Compare Source

  • restructured examples

v1.8.27

Compare Source

  • added call procedure with input table example and test

v1.8.26

Compare Source

  • updated dependencies
  • source code cleanups
  • performance improvements

v1.8.25

Compare Source

v1.8.25

v1.8.23

Compare Source

v1.8.23

v1.8.22

Compare Source

  • updated dependencies
  • source code cleanups
  • performance improvements

v1.8.21

Compare Source

  • experimental statement metadata

v1.8.20

Compare Source

  • changed minimal go version in go.mod to 1.21.0

v1.8.19

Compare Source

  • updated dependencies

v1.8.18

Compare Source

  • updated dependencies

v1.8.17

Compare Source

  • CWE-770 mitigation in bulkbench benchmark

v1.8.15

Compare Source

  • fixed sql value conversion for integers and floats

v1.8.14

Compare Source

  • fixed race condition in writing metrics

v1.8.12

Compare Source

  • updated dependencies

v1.8.11

Compare Source

  • fixed typo
  • fixed SQL datatype in StructScanner

v1.8.10

Compare Source

  • fixed regression on authentication refresh
  • updated dependencies

v1.8.9

Compare Source

  • updated dependencies

v1.8.7

Compare Source

  • fixed github action issue

v1.8.5

Compare Source

v1.8.5

v1.8.4

Compare Source

  • source code cleanups
  • performance improvements
  • updated dependencies

v1.8.3

Compare Source

  • updated README root certificate sections

v1.8.2

Compare Source

  • updated dependencies

v1.8.0

Compare Source

Minor revisions
v1.8.30
  • updated README root certificate sections
v1.8.29
  • updated dependencies
v1.8.28
  • restructured examples
v1.8.27
  • added call procedure with input table example and test
v1.8.22 - v1.8.26
  • updated dependencies
  • source code cleanups
  • performance improvements
v1.8.21
  • experimental statement metadata
v1.8.20
  • changed minimal go version in go.mod to 1.21.0
v1.8.18 - v1.8.19
  • updated dependencies
v1.8.17
  • CWE-770 mitigation in bulkbench benchmark
v1.8.16
v1.8.15
  • fixed sql value conversion for integers and floats
v1.8.14
  • fixed race condition in writing metrics
v1.8.13
  • updated dependencies
  • source code cleanups
v1.8.12
  • updated dependencies
v1.8.11
  • fixed typo
  • fixed SQL datatype in StructScanner
v1.8.10
  • fixed regression on authentication refresh
  • updated dependencies
v1.8.8 - v1.8.9
  • updated dependencies
v1.8.7
  • fixed github action issue
v1.8.4 - v1.8.6
  • source code cleanups
  • performance improvements
  • updated dependencies
v1.8.3
  • updated dependencies
v1.8.2
  • fixed github actions & CodeQL toolchain issues
v1.8.1
  • added toolchain
Changes
  • Added support of Go 1.22.
  • Dropped support of Go language versions < Go 1.21.
Incompatible changes
  • None.

v1.7.13

Compare Source

  • updated dependencies

v1.7.12

Compare Source

  • updated dependencies

v1.7.11

Compare Source

  • updated github action versions

v1.7.10

Compare Source

  • bulkbench fixes

v1.7.9

Compare Source

  • go1.22 preparation

v1.7.8

Compare Source

  • fixed issue closing connection before concurrent db calls are finalized

v1.7.7

Compare Source

  • source code cleanups

v1.7.6

Compare Source

  • updated dependencies
  • bulkbench refresh

v1.7.5

Compare Source

v1.7.4

Compare Source

  • performance improvements

v1.7.2

Compare Source

  • updated dependencies
  • go1.22 preparation

v1.7.1

Compare Source

  • updated dependencies

v1.7.0

Compare Source

Minor revisions
v1.7.12 - v1.7.13
  • updated dependencies
v1.7.11
  • updated github action versions
v1.7.10
  • bulkbench fixes
v1.7.9
  • go1.22 preparation
v1.7.8
  • fixed issue closing connection before concurrent db calls are finalized
v1.7.7
  • source code cleanups
v1.7.6
  • updated dependencies
  • bulkbench refresh
v1.7.5
v1.7.4
  • performance improvements
v1.7.3
  • updated dependencies
  • test performance improvements
v1.7.1 - v1.7.2
  • updated dependencies
  • go1.22 preparation
New features
  • Added driver support of scanning database rows into go structs.

v1.6.11

Compare Source

  • fixed github actions

v1.6.9

Compare Source

  • CESU8 decoding performance improvement
  • added time unit to stats

v1.6.8

Compare Source

  • updated dependencies
  • source code cleanups

v1.6.7

Compare Source

  • source code cleanups

v1.6.6

Compare Source

  • source code cleanups

v1.6.5

Compare Source

  • fixed linter issues

v1.6.4

Compare Source

  • updated dependencies
  • fixed linter issues

v1.6.3

Compare Source

  • updated dependencies

v1.6.2

Compare Source

  • fixed sqlscript parsing bug
  • updated dependencies

v1.6.1

Compare Source

  • fixed github actions

v1.6.0

Compare Source

Minor revisions
v1.6.11
  • fixed github actions
v1.6.10
  • source code cleanups
  • performance improvements
v1.6.9
  • CESU8 decoding performance improvement
  • added time unit to stats
v1.6.8
  • updated dependencies
  • source code cleanups
v1.6.6 - v1.6.7
  • source code cleanups
v1.6.5
  • fixed linter issues
v1.6.4
  • updated dependencies
  • fixed linter issues
v1.6.3
  • updated dependencies
v1.6.2
  • fixed sqlscript parsing bug
  • updated dependencies
v1.6.1
  • renamed sqlscript SplitFunc to ScanFunc
New features
  • Added experimental sqlscript package.

v1.5.10

Compare Source

  • updated dependencies

v1.5.9

Compare Source

v1.5.8

Compare Source

v1.5.7

Compare Source

v1.5.6

Compare Source

  • updated dependencies

v1.5.5

Compare Source

  • fixed driver.OpenDB dial tcp: missing address

v1.5.4

Compare Source

  • updated dependencies

v1.5.3

Compare Source

  • performance improvements

v1.5.2

Compare Source

  • fixed race condition in connection conn and stmt methods in case of context cancelling

v1.5.1

Compare Source

  • updated dependencies

v1.5.0

Compare Source

Minor revisions
v1.5.6 - v1.5.10
  • updated dependencies
v1.5.5
  • fixed driver.OpenDB dial tcp: missing address
v1.5.4
  • updated dependencies
v1.5.3
  • performance improvements
v1.5.2
  • fixed race condition in connection conn and stmt methods in case of context cancelling
v1.5.1
  • updated dependencies
New features
  • Added support of tenant database connection via tenant database name:
    • see new Connector method WithDatabase and
    • new DSN parameter DSNDatabaseName

v1.4.7

Compare Source

  • updated dependencies

v1.4.6

Compare Source

  • added go1.22 database/sql Null[T any] support

v1.4.5

Compare Source

  • updated dependencies

v1.4.4

Compare Source

  • source code cleanups

v1.4.3

Compare Source

  • updated documentation

v1.4.2

Compare Source

  • updated dependencies

v1.4.1

Compare Source

  • fixed bug: connection retry in case refresh callback has new version
  • updated dependencies

v1.4.0

Compare Source

Minor revisions
v1.4.7
  • updated dependencies
v1.4.6
  • added go1.22 database/sql Null[T any] support
v1.4.5
  • updated dependencies
v1.4.4
  • source code cleanups
v1.4.3
  • updated documentation
v1.4.2
  • updated dependencies
v1.4.1
  • fixed bug: connection retry in case refresh callback has new version
  • updated dependencies
Changes
  • Added support of Go 1.21.
  • Dropped support of Go language versions < Go 1.20.
Incompatible changes
  • None.

v1.3.16

Compare Source

  • updated dependencies

v1.3.15

Compare Source

  • fixed REUSE warnings

v1.3.14

Compare Source

  • preparation of go1.21 release

v1.3.13

Compare Source

  • updated dependencies

v1.3.12

Compare Source

  • source code cleanups

v1.3.11

Compare Source

v1.3.10

Compare Source

  • updated dependencies

v1.3.9

Compare Source

  • fixed bug: deadlock if refresh is called concurrently

v1.3.8

Compare Source

  • fixed bug: connection retry even in case refresh callback would not provide updates

v1.3.7

Compare Source

  • fixed bug pinging the database to often on resetting a connection
  • updated dependencies

v1.3.6

Compare Source

  • source code cleanups

v1.3.5

Compare Source

  • fixed authentication refresh issue when using more than one authentication method

v1.3.4

Compare Source

  • updated dependencies
  • slog go1.19 support

v1.3.3

Compare Source

  • updated dependencies

v1.3.2

Compare Source

  • updated dependencies
  • connection attribute logger instance getter and setter available for go1.20

v1.3.1

Compare Source

  • updated dependencies

v1.3.0

Compare Source

Minor revisions
v1.3.16
  • updated dependencies
v1.3.15
  • fixed REUSE warnings
v1.3.14
  • preparation of go1.21 release
v1.3.13
  • updated dependencies
v1.3.12
  • source code cleanups
v1.3.11
v1.3.10
  • updated dependencies
v1.3.9
  • fixed bug: deadlock if refresh is called concurrently
v1.3.8
  • fixed bug: connection retry even in case refresh callback would not provide updates
v1.3.7
  • fixed bug pinging the database to often on resetting a connection
  • updated dependencies
v1.3.6
  • source code cleanups
v1.3.5
  • fixed authentication refresh issue when using more than one authentication method
v1.3.4
  • updated dependencies
  • slog go1.19 support
v1.3.3
  • updated dependencies
v1.3.2
  • updated dependencies
  • connection attribute logger instance getter and setter available for go1.20
v1.3.1
  • use slog LogAttrs to improve performance and provide context if available
New features

go-hdb slog support. The slog package does provide structured logging and replaces
the standard logging output including SQL and protocol traces.

Incompatible changes
  • Logging output format changes, including SQL and protocol trace.

Most go-hdb users shouldn't be affected by these incompatible changes.

v1.2.7

Compare Source

  • updated dependencies

v1.2.6

Compare Source

  • fixed bug in cesu8 encoding

v1.2.5

Compare Source

  • updated dependencies
  • fixed typo in constant

v1.2.4

Compare Source

  • updated dependencies
  • removed outdated utf8 code in cesu8 encoding

v1.2.3

Compare Source

  • updated dependencies

v1.2.2

Compare Source

  • updated dependencies
  • pipx reuse check in Makefile
  • use errors.Join for go versions greater 1.19

v1.2.1

Compare Source

  • updated dependencies

This version is mainly about performance improvements and source code cleanups.

v1.2.0

Compare Source

Minor revisions
v1.2.7
  • updated dependencies
v1.2.6
  • fixed bug in cesu8 encoding
v1.2.5
  • updated dependencies
  • fixed typo in constant
v1.2.4
  • updated dependencies
  • removed outdated utf8 code in cesu8 encoding
v1.2.3
  • updated dependencies
v1.2.2
  • updated dependencies
  • pipx reuse check in Makefile
  • use errors.Join for go versions greater 1.19
v1.2.1
  • updated dependencies

This version is mainly about performance improvements and source code cleanups.

Incompatible changes
  • Package driver/sqltrace was removed. For enabling / disabling connection SQL trace please use driver method driver.SetSQLTrace instead.
  • Flag hdb.protocol.trace was renamed to hdb.protTrace.

Most go-hdb users shouldn't be affected by these incompatible changes.

v1.1.7

Compare Source

  • replaced build tag 'edan' by connector attribute EmptyDateAsNull

v1.1.6

Compare Source

v1.1.5

Compare Source

  • added build tag 'edan' to return NULL in case of empty dates for all data format versions
  • removed old build tags from source code

v1.1.4

Compare Source

  • performance improvements
  • updated dependencies

v1.1.3

Compare Source

  • updated dependencies

v1.1.2

Compare Source

  • updated dependencies

v1.1.1

Compare Source

  • fixed slice resize runtime error: slice bounds out of range

This version is mainly about performance improvements and source code cleanups.

v1.1.0

Compare Source

Minor revisions
v1.1.7
  • replaced build tag 'edan' by connector attribute EmptyDateAsNull
v1.1.6
v1.1.5
  • added build tag 'edan' to return NULL in case of empty dates for all data format versions
  • removed old build tags from source code
v1.1.4
  • performance improvements
  • updated dependencies
v1.1.3
  • updated dependencies
v1.1.2
  • updated dependencies
v1.1.1
  • fixed slice resize runtime error: slice bounds out of range

This version is mainly about performance improvements and source code cleanups.

Changes

Formerly with a ping interval defined the driver pinged all open connections periodically. Now a ping
is executed only when an idle connection is reused and the time since the last connection access
is greater than the ping interval. This avoids keeping idle connections to the server alive, improves
performance and is a compatible change from a driver's usage perspective.

v1.0.9

Compare Source

  • upgraded dependencies

v1.0.8

Compare Source

  • test performance improvements

v1.0.7

Compare Source

  • added implicit instantiation of NullLob and NullDecimal owned references in respective Scan methods

v1.0.6

Compare Source

  • some minor performance improvements and additional test

v1.0.5

Compare Source

  • fixed blob bulk sql statement issue

v1.0.4

Compare Source

  • fixed panic in case of bulk sql statement execution error

v1.0.3

Compare Source

  • fixed scan type for 'nullable' database fields

v1.0.2

Compare Source

  • fixed go.mod Go version

v1.0.1

Compare Source

  • added Go 1.20 Unwrap() to driver.Error()

v1.0.0

Minor revisions
v1.0.9
  • upgraded dependencies
v1.0.8
  • test performance improvements
v1.0.7
  • added implicit instantiation of NullLob and NullDecimal owned references in respective Scan methods
v1.0.6
  • some minor performance improvements and additional test
v1.0.5
  • fixed blob bulk sql statement issue
v1.0.4
  • fixed panic in case of bulk sql statement execution error
v1.0.3
  • fixed scan type for 'nullable' database fields
v1.0.2
  • fixed go.mod Go version
v1.0.1
  • added Go 1.20 Unwrap() to driver.Error()
Incompatible changes

Removal of already deprecated driver.NullTime alias (please use sql.NullTime instead).

Bulk operations:

  • The following bulk operations are no longer supported:
    • via query ("bulk insert ...")
    • via named arguments (Flush / NoFlush)
    • via 'many' supporting one and two dimensional slices, arrays
  • Please use the following bulk operations instead:
    • via extended parameter list with (len(args)%'#of paramerters' == 0
    • via function argument (func(args []any) error)

Stored procedures:

  • Calling stored procedures with sql.Query methods are no longer supported.
  • Please use sql.Exec methods instead and sql.Rows for table output parameters.
New features

  • Stored procedures executed by sql.Exec with parameters do

    • support named parameters and
    • support out output parameters

  • Custom types for reading Lobs

    Whereas string and []byte types are supported as Lob input parameters for output parameters and query results (scan) the driver.Lob type was needed.
    With the help of one of the following functions a string, []byte or io.Writer based custom type can now be used as well:

    • driver.ScanLobBytes
    • driver.ScanLobString
    • driver.ScanLobWriter

    Example:

    // BytesLob defines a []byte based data type for scanning Lobs.
type BytesLob []byte
// Scan implements the database.sql.Scanner interface.
func (b *BytesLob) Scan(arg any) error { return driver.ScanLobBytes(arg, (*[]byte)(b)) }

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies label Apr 3, 2024
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 7a5092c to 5591fe7 Compare April 5, 2024 20:42
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 9 times, most recently from 938d7c0 to 6d1eb9a Compare April 21, 2024 16:47
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 6d1eb9a to d74c35a Compare April 23, 2024 19:24
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 6 times, most recently from 7cd8128 to 527f1e9 Compare May 9, 2024 09:37
@coveralls
Copy link

coveralls commented May 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12020817342

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.443%
Totals Coverage Status
Change from base Build 12020761830: 0.0%
Covered Lines: 2052
Relevant Lines: 6325
💛 - Coveralls

@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 11 times, most recently from 9bc4999 to 84ceebb Compare May 15, 2024 21:51
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 2ae2312 to ccef99c Compare August 7, 2024 02:06
@renovate Renovate
Copy link
Contributor Author

renovate bot commented Aug 7, 2024 •
edited
Loading

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 4 additional dependencies were updated

Details:

Package Change
golang.org/x/crypto v0.25.0 -> v0.28.0
golang.org/x/sync v0.7.0 -> v0.8.0
golang.org/x/sys v0.22.0 -> v0.26.0
golang.org/x/text v0.16.0 -> v0.19.0

@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 4 times, most recently from 9dcfe31 to 30dd4a6 Compare August 15, 2024 11:21
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 30dd4a6 to 001a11f Compare August 28, 2024 17:11
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 5 times, most recently from 53acc79 to 2074e31 Compare September 12, 2024 11:04
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 2074e31 to 397cbe5 Compare October 3, 2024 13:51
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 5 times, most recently from 9679143 to 7711be1 Compare October 15, 2024 12:34
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 5 times, most recently from bbdb8d1 to 1854111 Compare October 28, 2024 11:50
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 2 times, most recently from c5eadfe to a43e437 Compare November 7, 2024 14:35
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from a43e437 to 7fc8928 Compare November 8, 2024 03:15
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch 2 times, most recently from 37bfa3c to 1a18466 Compare November 23, 2024 15:06
@renovate renovate bot force-pushed the renovate/github.com-sap-go-hdb-1.x branch from 1a18466 to c3193c7 Compare November 25, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coveralls