Step2 - 리팩터링(메뉴) #168
Open
Step2 - 리팩터링(메뉴) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihoony
requested changes
Oct 28, 2022
| public List<MenuGroup> findAll() { | ||
| return menuGroupRepository.findAll(); | ||
| public List<MenuGroupResponse> findAll() { | ||
| return menuGroupRepository.findAll().stream().map(v -> menuGroupMapper.toMenuGroupResponse(v)) |
There was a problem hiding this comment.
규칙 4: 한 줄에 점을 하나만 찍는다. 객체 지향 생활 체조 원칙을 지켜보면 좋을 것 같아요~^^
| import java.math.BigDecimal; | ||
| import java.util.UUID; | ||
|
|
||
| public class MenuProductResponse { |
There was a problem hiding this comment.
Setter가 필요한지 고민해보면 좋을 것 같아요. 우리는 이미 생성자를 통해서 데이터를 할당한것 같아요. ^^
다른 Response도 동일합니다.
Comment on lines
+37
to
+44
| @OneToMany(cascade = {CascadeType.PERSIST, CascadeType.MERGE}) | ||
| @JoinColumn( | ||
| name = "menu_id", | ||
| nullable = false, | ||
| columnDefinition = "binary(16)", | ||
| foreignKey = @ForeignKey(name = "fk_menu_product_to_menu") | ||
| ) | ||
| private List<MenuProduct> menuProducts; |
There was a problem hiding this comment.
일급객체를 활용해보는걸 추천드려요~^^
menuProducts의 책임과 역할이 명확하게 구분될 수 있을것 같네요.
|
|
||
| @Table(name = "menu") | ||
| @Entity | ||
| public class Menu { |
There was a problem hiding this comment.
Setter가 무분별하게 사용되지 않는지 생각해보면 좋을 것 같아요.
의미있는 Method는 코드를 읽기 좋게 만들어주죠!^^
Comment on lines
+111
to
+117
| if (isInvalidPrice(menuCreateRequest.getPrice(), menuProductList, productList)) { | ||
| throw new IllegalArgumentException("올바르지 않은 가격"); | ||
| } | ||
|
|
||
| if (isInvalidName(menuCreateRequest.getName(), purgomalumClient)) { | ||
| throw new IllegalArgumentException(); | ||
| } |
There was a problem hiding this comment.
검증은 별도의 Method로 분리해보는건 어떨까요~?
중복코드를 줄일 수 있겠네요.^^
| this.productId = productId; | ||
| } | ||
|
|
||
| public static List<MenuProduct> createMenuProductList(List<MenuProductRequest> menuProductRequestList, List<Product> productList) { |
There was a problem hiding this comment.
Entity가 MenuProductRequest를 활용해야 되는 상황이네요.
Entity는 DTO를 모르는 상황을 만들어 준다면?? Entity는 결합도가 낮아질 것 같아요.^^
이런 의견을 나누는 글도 있었네요.^^
강의내용을 다시봐도 좋을 것 같아요~^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
메뉴에 대한 리팩토링을 진행했습니다