feat: step2 기능구현 #376
Open
feat: step2 기능구현 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sah3122
requested changes
Nov 28, 2023
Comment on lines
+31
to
+32
| for (i in -1..1) { | ||
| for (j in -1..1) { |
There was a problem hiding this comment.
반복문을 사용하여 주변 지뢰를 찾는것도 좋지만 이번 미션을 진행하며 작은 단위의 클래스를 도출하는 연습을 하는것을 권장 드립니다.
방향을 나타내는 클래스를 정의하여 주변의 지뢰를 찾아보는건 어떨까요 ?
| class MinePoint(val isMine: Boolean) | ||
|
|
||
|
|
||
| class MinePoint(val isMine: Boolean, val mineCountNear: Int = 0) |
There was a problem hiding this comment.
MinePoint 클래스만 활용하여 지뢰, 지뢰가 아닌 위치를 나타내기보단 추상화를 도입하여 보는것을 권장 드립니다 😄
Comment on lines
+23
to
+27
| _map.forEachIndexed { col, colList -> | ||
| colList.forEachIndexed { row, minePoint -> | ||
| _map[col][row]= MinePoint(minePoint.isMine, getNearMineCount(col, row)) | ||
| } | ||
| } |
| @@ -10,12 +13,33 @@ class GameMap(height: Int, width: Int, mineCount: Int) { | |||
| val mines = positions.take(mineCount) | |||
|
|
|||
| // 맵 생성 | |||
| map = List(height) { col -> | |||
| List(width) { row -> | |||
| _map = MutableList(height) { col -> | |||
There was a problem hiding this comment.
_map 객체를 backing property 로 정의하지않고 init block에서만 선언해도 될것 같은데 어떻게 생각하시나요 ?
| @@ -1,7 +1,10 @@ | |||
| package model | |||
|
|
|||
| class GameMap(height: Int, width: Int, mineCount: Int) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 간단하게 구현했습니다!