Skip to content
This repository has been archived by the owner on Jul 17, 2022. It is now read-only.

Allow larger id_token in typeorm adapter #336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thgh
Copy link

@thgh thgh commented Dec 5, 2021

Reasoning 💡

This resolved my issue with sign in with Google using TypeORM and seems applicable to everyone.

This change raises the max size from 255 to 65k characters.

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

Resolves nextauthjs/next-auth#3825

@github-actions github-actions bot added the typeorm @next-auth/typeorm-legacy-adapter related label Dec 5, 2021
@balazsorban44
Copy link
Member

This would be a breaking change since this is changing the schema, right? Could you update your description with that info for future reference?

We just released 1.0 though, it might be a bit early to include such a change... 🤷 We might either want to wait for multiple such changes. What do you think?

We document how to use custom models here: https://next-auth.js.org/adapters/typeorm#custom-models

@stale
Copy link

stale bot commented May 25, 2022

Hi there! It looks like this issue hasn't had any activity for a while. It will be closed if no further activity occurs. If you think your issue is still relevant, feel free to comment on it to keep it open. Thanks!

@stale stale bot added the stale label May 25, 2022
@thgh
Copy link
Author

thgh commented Jun 8, 2022

I think TypeORM can change the column type without losing data. But I'm using Prisma now, so not sure about it!

@stale stale bot removed the stale label Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typeorm @next-auth/typeorm-legacy-adapter related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeorm-legacy. Login with Google Account: ER_DATA_TOO_LONG: Data too long for column 'id_token' at row
2 participants