Skip to content

Commit

Permalink
Replace horizontal scrolling with vertical scrolling on small screens…
Browse files Browse the repository at this point in the history
… in app settings navigation

Signed-off-by: julia.kirschenheuter <[email protected]>
  • Loading branch information
JuliaKirschenheuter committed Nov 17, 2023
1 parent 5db6b10 commit 67864fc
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ export default {
@update:open="handleCloseModal">
<template #navigation="{ isCollapsed }">
<ul :aria-label="settingsNavigationAriaLabel"
v-show="!isCollapsed"

Check warning on line 148 in src/components/NcAppSettingsDialog/NcAppSettingsDialog.vue

View workflow job for this annotation

GitHub Actions / eslint

Attribute "v-show" should go before ":aria-label"
:class="{ 'navigation-list': true, 'navigation-list--collapsed': isCollapsed }"
role="tablist">
<li v-for="section in sections" :key="section.id">
Expand Down Expand Up @@ -469,4 +470,12 @@ export default {
}
}

@media only screen and (max-width: 320px) {
.navigation-list {
&--collapsed {
display: none;
}
}
}

</style>

0 comments on commit 67864fc

Please sign in to comment.