Skip to content

Commit

Permalink
fix: app-navigation-toggle remains on screen on small viewports
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Morales <[email protected]>
  • Loading branch information
emoral435 committed Jan 26, 2024
1 parent 7d726b4 commit 753f5c2
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions src/components/NcAppNavigationToggle/NcAppNavigationToggle.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ import { t } from '../../l10n.js'
import MenuIcon from 'vue-material-design-icons/Menu.vue'
import MenuOpenIcon from 'vue-material-design-icons/MenuOpen.vue'

/**
* The NcAppNavigationToggle component is used typically alongside another header navigation component.
* It emits the status of whether the button has been clicked or not.
*
*/
export default {
name: 'NcAppNavigationToggle',

Expand All @@ -55,6 +60,11 @@ export default {
},

props: {
/**
* Tracks whether the toggle has been clicked or not.
* If it has been clicked, switches between the different MenuIcons
* and emits a boolean indicating its opened status
*/
open: {
type: Boolean,
required: true,
Expand All @@ -69,6 +79,10 @@ export default {
},
},
methods: {
/**
* Once the toggle has been clicked, emits the toggle status
* so parent components can gauge the status of the navigation button
*/
toggleNavigation() {
this.$emit('update:open', !this.open)
},
Expand All @@ -87,4 +101,11 @@ export default {
button.app-navigation-toggle {
background-color: var(--color-main-background);
}

@media only screen and (max-width: $breakpoint-small-mobile) {
// Positions the navigation toggle button on the smallers screens to still be visible
button.app-navigation-toggle {
right: -6px !important;
}
}
</style>

0 comments on commit 753f5c2

Please sign in to comment.