-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcHeaderMenu): mouse in now pointer #5101
fix(NcHeaderMenu): mouse in now pointer #5101
Conversation
3c20dc6
to
9e60e4f
Compare
9e60e4f
to
8e457e3
Compare
8e457e3
to
e3bf888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -363,10 +364,6 @@ $externalMargin: 8px; | |||
opacity: 1; | |||
} | |||
|
|||
&__trigger:focus-visible { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to stay, see @Pytal comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes because both have the same specificity, you also can just increase it, currently the style is just on .header-menu__trigger
, but it should work with .header-menu .header-menu__trigger:focus-visible
.
Something like:
.header-menu {
// ...
#{&}__trigger:focus-visible {
// here
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it is better just an option ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, only now do I get what you mean! I changed it to how you requested, actually, because your solution uses something similar with the Unified Search fix in nextcloud/server#42978 , I will use your solution (plus I try not to use :deep
as much as possible)
e3bf888
to
38f8ed9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks code, style looks style!
1aefe9b
to
9b77ed5
Compare
Signed-off-by: Eduardo Morales <[email protected]>
9b77ed5
to
6cdf138
Compare
There is a slight regression where the trigger button width of 50px is being overidden by NcButton width of 44px @emoral435 |
Gotcha 👍 will fix that right now, and send out the new version. Embarrassed that I did not notice this 🫠 thank you! |
☑️ For nextcloud/server#42959
🖼️ Screenshots
🏡 After
🚧 Tasks
🏁 Checklist