Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcRichContenteditable): do not break adjacent mentions #6240

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 19, 2024

Backport of #6223

Warning, This backport's changes differ from the original and might be incomplete ⚠️

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Nov 19, 2024
- when injecting HTML template, newlines, tabs and consecutive whitespaces should be stripped
- when parsing innerHTML (reverse process), collapsing of whitespacing also affecting two adjacent HTML templates
- parsed ids without whitespace will be joined and won't be rendered next time

Signed-off-by: Maksim Sukharev <[email protected]>

(cherry picked from commit 1a831ef)
Signed-off-by: Maksim Sukharev <[email protected]>
- sanitized strings are skipped

Signed-off-by: Maksim Sukharev <[email protected]>

(cherry picked from commit f62f921)
Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy marked this pull request as ready for review November 19, 2024 16:41
@Antreesy Antreesy added this to the 9.0.0-alpha.6 milestone Nov 19, 2024
@ShGKme ShGKme merged commit 601d477 into next Nov 19, 2024
21 checks passed
@ShGKme ShGKme deleted the backport/6223/next branch November 19, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants