Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat!: remove plugin #6349

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[next] feat!: remove plugin #6349

merged 1 commit into from
Jan 20, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 4, 2025

☑️ Resolves

Using plugin was not recommended in v8.

It is generally a bad idea to import all the components, resulting in a slow build of a large bundle.
Only used components should be imported and registered locally.

If a library user wants to avoid imports, they can use unplugin-vue-components as an alternative even keeping tree-shaking.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added enhancement New feature or request 2. developing Work in progress breaking PR that requires a new major version labels Jan 4, 2025
@ShGKme ShGKme added this to the 9.0.0-alpha.6 milestone Jan 4, 2025
@ShGKme ShGKme changed the title feat!: remove plugin [next] feat!: remove plugin Jan 17, 2025
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 17, 2025
@ShGKme ShGKme force-pushed the feat/remove-plugin branch from 221b130 to 9084c0a Compare January 17, 2025 20:37
@ShGKme ShGKme marked this pull request as ready for review January 17, 2025 20:37
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme force-pushed the feat/remove-plugin branch from 9084c0a to 49f23a9 Compare January 20, 2025 10:05
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 20, 2025

Rebased, conflick in the changelog resolved

@ShGKme ShGKme enabled auto-merge January 20, 2025 10:06
@ShGKme ShGKme merged commit bbe10d1 into next Jan 20, 2025
20 checks passed
@ShGKme ShGKme deleted the feat/remove-plugin branch January 20, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants