Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): move EOL date to config.php instead of boolean #1082

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Altahrim
Copy link
Contributor

@Altahrim Altahrim commented Jun 28, 2024

EOL flag is now computed when serving response

Pro

  • Will send EOL flag as soon as EOL date is reached, without changing the config.php
  • Add EOL date as info for Nextcloud

Cons

  • Any major split with XX.Y and XX.Z will not have different EOL.
    For instance, 27.0 couldn't be EOL if 27.1 isn't. This could be improved later.

@Altahrim Altahrim self-assigned this Jun 28, 2024
@Altahrim Altahrim force-pushed the feat/eol-config branch 3 times, most recently from 5a11a67 to e16e351 Compare June 28, 2024 13:56
EOL flag is now computed when serving response

Signed-off-by: Benjamin Gaussorgues <[email protected]>
@blizzz
Copy link
Contributor

blizzz commented Jun 28, 2024

Any major split with XX.Y and XX.Z will not have different EOL.
For instance, 27.0 couldn't be EOL if 27.1 isn't. This could be improved later.

That's not necessary, it is the same series.

@blizzz
Copy link
Contributor

blizzz commented Jun 28, 2024

Good with me!

@nickvergessen
Copy link
Contributor

That's not necessary, it is the same series.

Security wise it's actually the opposite. 27.0 was EOLed by the release of 27.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants