Add ENV variables to adjust max_file_uploads and max_chunk_size #5449
Conversation
Signed-off-by: JMarcosHP <[email protected]>
szaimen
added
3. to review
|
Hi @JMarcosHP , thanks a lot for the PR! Did you already do the following #5095 (reply in thread)? Did it make it work for you? (We need this information in order to judge if it makes sense to merge your PR going forward) |
Hi, yes I've tested my self that parameters and fixed my issue, hope this will help Cloudflare Tunnel users. By adjusting the chunk size you can improve upload speeds. |
…AX_FILE_UPLOADS Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
…You need a space before the ]. [SC1020]" Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
|
I think now this is ready for review and merge. |
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
|
First of all thanks a lot for your PR! The thing is that with nextcloud/server#45652 (which brings chunking for public uploads) and nextcloud/server#47682 which consists of nextcloud/server#48461 and nextcloud/desktop#7161 that improves the default chunking situation, I'd like to wait for Nextcloud 31 and a Desktop client release that includes the change first and afterwards re-evaluate the situation to check if we actually need this setting afterwards. I hope this makes sense? |
All right Sir, let's wait for Nextcloud 31. 👌🏻
|
| @@ -122,6 +123,7 @@ RUN set -ex; \ | |||
| { \ | |||
| echo 'memory_limit=${PHP_MEMORY_LIMIT}'; \ | |||
| echo 'upload_max_filesize=${PHP_UPLOAD_LIMIT}'; \ | |||
| echo 'max_file_uploads=${PHP_MAX_FILE_UPLOADS}'; \ | |||
There was a problem hiding this comment.
Just so that this info does not get lost: #5095 (reply in thread)
Close #5095