Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use REPORT for favorite search #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Apr 10, 2019

@AndyScherzinger
Copy link
Member

Hmm, looking at the number of commits it seems a rebase since this is still in development would trim the number of changes quite a bit :)

@nextcloud nextcloud deleted a comment Aug 9, 2019
AndyScherzinger
AndyScherzinger previously approved these changes Aug 9, 2019
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

private static final int RESTORE_READ_TIMEOUT = 30000;
private static final int RESTORE_CONNECTION_TIMEOUT = 5000;

private ArrayList<Object> favorites;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use List as a collection interface :)

Signed-off-by: tobiasKaminsky <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #273 into master will decrease coverage by 8.71%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
- Coverage   31.62%   22.91%   -8.72%     
==========================================
  Files         120      118       -2     
  Lines        5280     5259      -21     
  Branches      704      703       -1     
==========================================
- Hits         1670     1205     -465     
- Misses       3387     3930     +543     
+ Partials      223      124      -99
Impacted Files Coverage Δ
...ncloud/android/lib/common/network/WebdavEntry.java 73.65% <ø> (+1.29%) ⬆️
...b/resources/files/GetFavoritesRemoteOperation.java 94.11% <94.11%> (ø)
...d/android/lib/resources/shares/ShareXMLParser.java 0% <0%> (-83.44%) ⬇️
...b/resources/shares/RemoveShareRemoteOperation.java 0% <0%> (-72%) ⬇️
...lib/resources/shares/GetSharesRemoteOperation.java 0% <0%> (-69.57%) ⬇️
...ncloud/android/lib/resources/shares/ShareType.java 0% <0%> (-69.57%) ⬇️
...b/resources/shares/CreateShareRemoteOperation.java 0% <0%> (-68%) ⬇️
...resources/files/ExistenceCheckRemoteOperation.java 0% <0%> (-61.12%) ⬇️
...d/lib/resources/files/CopyFileRemoteOperation.java 0% <0%> (-58.54%) ⬇️
...oud/android/lib/resources/status/OCCapability.java 0% <0%> (-50.52%) ⬇️
... and 27 more

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings60
Total164

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings59
Total163

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants