-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use REPORT for favorite search #273
base: master
Are you sure you want to change the base?
Conversation
5b4130d
to
d367e07
Compare
Hmm, looking at the number of commits it seems a rebase since this is still in development would trim the number of changes quite a bit :) |
adff7d8
to
48e06e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment
private static final int RESTORE_READ_TIMEOUT = 30000; | ||
private static final int RESTORE_CONNECTION_TIMEOUT = 5000; | ||
|
||
private ArrayList<Object> favorites; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use List as a collection interface :)
Signed-off-by: tobiasKaminsky <[email protected]>
48e06e0
to
b0d5cb3
Compare
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 31.62% 22.91% -8.72%
==========================================
Files 120 118 -2
Lines 5280 5259 -21
Branches 704 703 -1
==========================================
- Hits 1670 1205 -465
- Misses 3387 3930 +543
+ Partials 223 124 -99
|
Lint
SpotBugs (new)
SpotBugs (master)
SpotBugs increased! |
Waits for:
nextcloud/server#15029nextcloud/3rdparty#264nextcloud/server#17586
Signed-off-by: tobiasKaminsky [email protected]