Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.30] Fix FileDetailFragment not starting #14326

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 7, 2025

Backport of #14051

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport was not successfully created

@ZetaTom ZetaTom force-pushed the backport/14051/stable-3.30 branch from d47d2ce to 0b9c944 Compare January 7, 2025 13:27
Copy link

github-actions bot commented Jan 7, 2025

Lint

Typestable-3.30PR
Warnings60136
Errors39

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Multithreaded correctness77
Performance5353
Security1818
Total511511

Lint increased!

@alperozturk96 alperozturk96 marked this pull request as ready for review January 8, 2025 12:25
- opens on specified tab

- opens when launched from PreviewImageActivity

Signed-off-by: ZetaTom <[email protected]>
@alperozturk96 alperozturk96 force-pushed the backport/14051/stable-3.30 branch from 0b9c944 to 26296f5 Compare January 8, 2025 12:25
Copy link

github-actions bot commented Jan 8, 2025

Lint

Typestable-3.30PR
Warnings60136
Errors39

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6262
Dodgy code300300
Experimental11
Internationalization77
Multithreaded correctness77
Performance5353
Security1818
Total511511

Lint increased!

Copy link

github-actions bot commented Jan 8, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14326.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Jan 8, 2025

@tobiasKaminsky tobiasKaminsky merged commit 1fca604 into stable-3.30 Jan 13, 2025
17 of 19 checks passed
@tobiasKaminsky tobiasKaminsky deleted the backport/14051/stable-3.30 branch January 13, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants