Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bottom Navigation Bar From File Details #14343

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove Bottom Navigation Bar From File Details #14343

merged 1 commit into from
Jan 21, 2025

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jan 8, 2025 •
edited
Loading

  • Tests written, or not not needed
Scr.mp4

@alperozturk96 alperozturk96 linked an issue Jan 8, 2025 that may be closed by this pull request
Bottom bar is shown in file details #14288
Closed
@alperozturk96 alperozturk96 requested a review from ZetaTom January 8, 2025 11:21
@alperozturk96 alperozturk96 force-pushed the remove-bottom-bar-from-file-details branch 2 times, most recently from 4d32a78 to 5a23d44 Compare January 9, 2025 14:02
@tobiasKaminsky tobiasKaminsky force-pushed the remove-bottom-bar-from-file-details branch from 5a23d44 to 9f19f87 Compare January 14, 2025 09:31
@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.31.0 milestone Jan 21, 2025
@tobiasKaminsky tobiasKaminsky force-pushed the remove-bottom-bar-from-file-details branch from 9f19f87 to 8ee2716 Compare January 21, 2025 09:36
@alperozturk96 @tobiasKaminsky
fix
e31ea78 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky tobiasKaminsky force-pushed the remove-bottom-bar-from-file-details branch from 8ee2716 to e31ea78 Compare January 21, 2025 10:43
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14343.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5555
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total504504

@tobiasKaminsky tobiasKaminsky merged commit de514e1 into master Jan 21, 2025
20 checks passed
@tobiasKaminsky tobiasKaminsky deleted the remove-bottom-bar-from-file-details branch January 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.31.0
Development

Successfully merging this pull request may close these issues.

Bottom bar is shown in file details
2 participants
@alperozturk96 @tobiasKaminsky