Stop Uploads When the Device Doesn’t Have an Internet Connection #14364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
stop-upload-when-device-not-have-internet-connection
branch
2 times, most recently
from
4ae3b5e to
a155284
Compare
| fun showConnectionErrorNotification() { | ||
| notificationBuilder.run { | ||
| setContentTitle(context.getString(R.string.file_upload_worker_error_notification_title)) | ||
| setContentText("") |
There was a problem hiding this comment.
Will it retry once a network connection is detected?
If so, we can add this info here as text.
There was a problem hiding this comment.
If the FileUploadWorker is triggered for auto-upload, it will run again. However, if it is triggered for manual file upload, it will not. We could indicate this detail, but it might be too much information for the user.
alperozturk96
force-pushed
the
stop-upload-when-device-not-have-internet-connection
branch
2 times, most recently
from
402220c to
a17ce74
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
stop-upload-when-device-not-have-internet-connection
branch
from
1b6af1b to
6966ce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the device lacks an active internet connection or is in airplane mode, the app continues attempting to upload files. This results in numerous “upload failed” notifications appearing repeatedly.
How to Test