optimization: remove profile since unused (#321)

Ongoing optimization by removing redundant or unused parts --------- Signed-off-by: Andrey Borysenko <[email protected]> Co-authored-by: Alexander Piskun <[email protected]>
nextcloud · Jul 10, 2024 · d9a03f6 · d9a03f6
1 parent 7820f65
commit d9a03f6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 70 deletions.
diff --git a/lib/AppInfo/Application.php b/lib/AppInfo/Application.php
@@ -18,7 +18,6 @@
 use OCA\AppAPI\Middleware\ExAppUiMiddleware;
 use OCA\AppAPI\Notifications\ExAppAdminNotifier;
 use OCA\AppAPI\Notifications\ExAppNotifier;
-use OCA\AppAPI\Profiler\AppAPIDataCollector;
 use OCA\AppAPI\PublicCapabilities;
 use OCA\AppAPI\Service\ProvidersAI\SpeechToTextService;
 use OCA\AppAPI\Service\ProvidersAI\TaskProcessingService;
@@ -44,7 +43,6 @@
 use OCP\IURLGenerator;
 use OCP\IUser;
 use OCP\IUserSession;
-use OCP\Profiler\IProfiler;
 use OCP\SabrePluginEvent;
 use OCP\Settings\Events\DeclarativeSettingsGetValueEvent;
 use OCP\Settings\Events\DeclarativeSettingsRegisterFormEvent;
@@ -114,10 +112,6 @@ public function register(IRegistrationContext $context): void {
 	public function boot(IBootContext $context): void {
 		$server = $context->getServerContainer();
 		try {
-			$profiler = $server->get(IProfiler::class);
-			if ($profiler->isEnabled()) {
-				$profiler->add(new AppAPIDataCollector());
-			}
 			$context->injectFn($this->registerExAppsManagementNavigation(...));
 			$context->injectFn($this->registerExAppsMenuEntries(...));
 		} catch (NotFoundExceptionInterface|ContainerExceptionInterface|Throwable) {

diff --git a/lib/Profiler/AppAPIDataCollector.php b/lib/Profiler/AppAPIDataCollector.php
diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -11,15 +11,15 @@
   </file>
   <file src="lib/Controller/ExAppProxyController.php">
     <UndefinedClass>
-      <code>CookieJar</code>
-      <code>CookieJar</code>
-      <code>RequestOptions</code>
-      <code>RequestOptions</code>
-      <code>RequestOptions</code>
-      <code>RequestOptions</code>
-      <code>RequestOptions</code>
-      <code>RequestOptions</code>
-      <code>SetCookie</code>
+      <code><![CDATA[CookieJar]]></code>
+      <code><![CDATA[CookieJar]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[RequestOptions]]></code>
+      <code><![CDATA[SetCookie]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/Controller/ExAppsPageController.php">
@@ -105,9 +105,4 @@
       <code><![CDATA[IEventListener]]></code>
     </MissingTemplateParam>
   </file>
-  <file src="lib/Profiler/AppAPIDataCollector.php">
-    <UndefinedClass>
-      <code><![CDATA[Request]]></code>
-    </UndefinedClass>
-  </file>
 </files>