Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PHP8.2 in CI test matrix #4708

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 31, 2022

For nextcloud/groupware#40

The early bird catches the PHP8.2 bug

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement New feature request labels Oct 31, 2022
@ChristophWurst ChristophWurst added this to the v4.2.0 milestone Oct 31, 2022
@ChristophWurst ChristophWurst self-assigned this Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 41.53% // Head: 41.57% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (ceeefbc) compared to base (7c84233).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4708      +/-   ##
============================================
+ Coverage     41.53%   41.57%   +0.04%     
  Complexity      338      338              
============================================
  Files           225      225              
  Lines          5632     5638       +6     
  Branches        738      738              
============================================
+ Hits           2339     2344       +5     
- Misses         3293     3294       +1     
Flag Coverage Δ
javascript 31.42% <66.66%> (+<0.01%) ⬆️
php 68.57% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
src/views/Calendar.vue 0.00% <ø> (ø)
src/store/settings.js 94.28% <100.00%> (+0.05%) ⬆️
...s/calendar/lib/Controller/PublicViewController.php 100.00% <0.00%> (ø)
...ud/apps/calendar/lib/Controller/ViewController.php 80.95% <0.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miaulalala miaulalala merged commit db492b5 into main Oct 31, 2022
@miaulalala miaulalala deleted the enhancement/php8.2-test-ci branch October 31, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants