Merge pull request #903 from nextcloud/chore/nextcloud-eslint-and-babel

chore: migrate to @nextcloud/eslint-config and @nextcloud/babel-config

.eslintrc.js

@@ -1,41 +1,5 @@
 module.exports = {
-	root: true,
-	env: {
-		browser: true,
-		es6: true,
-		node: true
-	},
-	globals: {
-		dav: true
-	},
-	extends: ['eslint:recommended', 'plugin:node/recommended', 'standard'],
-	plugins: ['node'],
-	rules: {
-		// space before function ()
-		'space-before-function-paren': ['error', 'never'],
-		// curly braces always space
-		'object-curly-spacing': ['error', 'always'],
-		'array-bracket-spacing': ['error', 'never'],
-		// stay consistent with array brackets
-		'array-bracket-newline': ['error', 'consistent'],
-		// 1tbs brace style
-		'brace-style': 'error',
-		// tabs only
-		indent: ['error', 'tab'],
-		'no-tabs': 0,
-		// only debug console
-		'no-console': ['error', { allow: ['error', 'warn', 'debug'] }],
-		// classes blocks
-		'padded-blocks': ['error', { classes: 'always' }],
-		// always have the operator in front
-		'operator-linebreak': ['error', 'before'],
-		// ternary on multiline
-		'multiline-ternary': ['error', 'always-multiline'],
-		// es6 import/export and require
-		'node/no-unsupported-features/es-syntax': ['off'],
-		// disable the recommended no-extra-semi
-		semi: ['error', 'always'],
-		// dot notation exclusion for uppercase first letters variables
-		'dot-notation': ['error', { allowPattern: '^[A-Z][a-zA-Z]+$' }]
-	}
-};
+	extends: [
+		'@nextcloud',
+	],
+}

babel.config.js

@@ -1,11 +1,3 @@
-module.exports = {
-	presets: [
-		[
-			'@babel/preset-env',
-			{
-				useBuiltIns: 'usage',
-				corejs: 3
-			}
-		]
-	]
-}
+const babelConfig = require('@nextcloud/babel-config')
+
+module.exports = babelConfig

package.json

@@ -43,14 +43,10 @@
   },
   "devDependencies": {
     "@babel/core": "^7.16.0",
-    "@babel/preset-env": "^7.16.4",
+    "@nextcloud/babel-config": "^1.2.0",
     "@nextcloud/browserslist-config": "^3.0.0",
-    "babel-eslint": "^10.1.0",
+    "@nextcloud/eslint-config": "^8.4.1",
     "babel-loader": "^9.1.0",
-    "eslint": "^7.32.0",
-    "eslint-config-standard": "^16.0.3",
-    "eslint-loader": "^4.0.2",
-    "eslint-plugin-node": "^11.1.0",
     "istanbul": "^0.4.5",
     "jasmine": "^5.0.0",
     "karma": "^6.3.9",
@@ -62,9 +58,5 @@
     "webpack": "^5.65.0",
     "webpack-cli": "^5.0.0",
     "webpack-merge": "^5.8.0"
-  },
-  "dependencies": {
-    "core-js": "^3.19.3",
-    "regenerator-runtime": "^0.14.0"
   }
 }

src/debug.js

@@ -23,16 +23,16 @@
 
 /**
  * creates a debug function bound to a context
- * @param {String} context
- * @returns {Function}
+ * @param {string} context
+ * @return {Function}
  */
 export function debugFactory(context) {
 	return (...args) => {
 		if (debugFactory.enabled) {
 			// eslint-disable-next-line no-console
-			console.debug(context, ...args);
+			console.debug(context, ...args)
 		}
-	};
+	}
 }
 
-debugFactory.enabled = false;
+debugFactory.enabled = false

src/errors/attachError.js

@@ -30,12 +30,12 @@ export default class AttachError extends Error {
 
 	/**
 	 *
-	 * @param {Object} attach
+	 * @param {object} attach
 	 */
 	constructor(attach) {
-		super();
+		super()
 
-		Object.assign(this, attach);
+		Object.assign(this, attach)
 	}
 
 }

src/errors/networkRequestAbortedError.js

@@ -21,6 +21,6 @@
  *
  */
 
-import AttachError from './attachError.js';
+import AttachError from './attachError.js'
 
 export default class NetworkRequestAbortedError extends AttachError {}

src/errors/networkRequestClientError.js

@@ -21,6 +21,6 @@
  *
  */
 
-import NetworkRequestHttpError from './networkRequestHttpError.js';
+import NetworkRequestHttpError from './networkRequestHttpError.js'
 
 export default class NetworkRequestClientError extends NetworkRequestHttpError {}

src/errors/networkRequestError.js

@@ -21,6 +21,6 @@
  *
  */
 
-import AttachError from './attachError.js';
+import AttachError from './attachError.js'
 
 export default class NetworkRequestError extends AttachError {}

src/errors/networkRequestHttpError.js

@@ -21,6 +21,6 @@
  *
  */
 
-import AttachError from './attachError.js';
+import AttachError from './attachError.js'
 
 export default class NetworkRequestHttpError extends AttachError {}

src/errors/networkRequestServerError.js

@@ -21,6 +21,6 @@
  *
  */
 
-import NetworkRequestHttpError from './networkRequestHttpError.js';
+import NetworkRequestHttpError from './networkRequestHttpError.js'
 
 export default class NetworkRequestServerError extends NetworkRequestHttpError {}