Birthday, Date of Death, Anniversary save wrong date

[thrawn-sh]

Describe the bug

When entering / modifying a date in a Birthday, Date of Death, Anniversary the resulting date is off-by-one for the month

To Reproduce
Steps to reproduce the behavior:

1. Go to a contact
2. Click on "Choose property type" of "Add new property"
3. Select Birthday, Date of Death or Anniversary
4. Pre-filled value is the current date (correct)
5. Select an other date

Expected behavior
The property displays the selected date.

Actual behavior
The property displays a date, that is of-by-one for the month

Screenshots

Server configuration

Operating system: Linux

Web server: Nginx

Database: PostgreSQL

PHP version: 7.0.33-0+deb9u1

Nextcloud version: 15.0.0

Contacts version: 3.0.1

Updated from an older Nextcloud or fresh install: Update

Signing status:

No errors have been found.

List of activated apps:

Enabled:
  - bruteforcesettings: 1.3.0
  - calendar: 1.6.4
  - cloud_federation_api: 0.1.0
  - contacts: 3.0.1
  - dav: 1.8.0
  - federatedfilesharing: 1.5.0
  - files: 1.10.0
  - files_sharing: 1.7.0
  - files_texteditor: 2.7.0
  - files_trashbin: 1.5.0
  - files_videoplayer: 1.4.0
  - gallery: 18.2.0
  - gpxedit: 0.0.10
  - gpxpod: 3.0.0
  - impersonate: 1.2.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.3.0
  - metadata: 0.8.0
  - nextcloud_announcements: 1.4.0
  - notifications: 2.3.0
  - oauth2: 1.3.0
  - provisioning_api: 1.5.0
  - richdocuments: 3.1.0
  - serverinfo: 1.5.0
  - sharebymail: 1.5.0
  - tasks: 0.9.8
  - twofactor_backupcodes: 1.4.1
  - updatenotification: 1.5.0
  - user_ldap: 1.5.0
  - workflowengine: 1.5.0
Disabled:
  - accessibility
  - activity
  - admin_audit
  - comments
  - encryption
  - federation
  - files_external
  - files_pdfviewer
  - files_versions
  - firstrunwizard
  - password_policy
  - support
  - survey_client
  - systemtags
  - theming
  - user_external

{
    "system": {
        "appstore.experimental.enabled": false,
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "loglevel": 4,
        "logtimezone": "UTC",
        "maintenance": false,
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "7, 14",
        "trusted_domains": [
             "***REMOVED SENSITIVE VALUE***",
             "***REMOVED SENSITIVE VALUE***"
        ],
        "version": "15.0.0.10",
        "theme": "",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "dbtype": "pgsql",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "5432",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": 587,
        "mail_smtpsecure": "tls",
        "mail_smtpauth": true,
        "mail_smtpauthtype": "PLAIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG"
        ],
        "overwrite.cli.url":  "***REMOVED SENSITIVE VALUE***"
    }
}

Client configuration

Browser:
Friefox 64
Chromium 71.0.3578.80

Operating system:
Linux

CardDAV-clients:

Logs

Web server error log

No error in the log

Nextcloud log

data/nextcloud.log

No entry for Debug/Info/Warning/Error/Fatal

Browser log

Browser Log/Console is empty

[nextcloud-bot]

GitMate.io thinks possibly related issues are #507 (Contact could not be saved if both birthday and date of birth given), #501 (Contact could not be saved if both anniversary and birthday), #781 (Can not add "Date of Death" to contacts), #257 (Wrong Etag return from server prevents modifications from being saved ), and #314 (Saved searches).

[1ndahous3]

+

[tilllt]

Selecting ANY Month will result in the the Date going back one Month from the last selected month. Totally broken Behaviour.

[tilllt]

Also it should be able to save Birthday without a time, i think its rather unusual to save a time to a Birtday.

[tagnullde]

When you set the month 12 times, I will wrap around and will show "invalid date".

[skjnldsv]

Duplicate of #796