Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump @nextcloud/eslint-config from 8.3.0-beta.2 to 8.3.0 #3639

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2023

Bumps @nextcloud/eslint-config from 8.3.0-beta.2 to 8.3.0.

Release notes

Sourced from @​nextcloud/eslint-config's releases.

v8.3.0

v8.3.0 (2023-09-24)

Full Changelog

Features

Fixes

Changed

Changelog

Sourced from @​nextcloud/eslint-config's changelog.

v8.3.0 (2023-09-25)

Full Changelog

Features

Fixes

Changed

v8.2.1 (2023-01-30)

Full Changelog

Fixed:

Merged pull requests:

  • Various dependencies upgrades

v8.2.0 (2023-01-11)

Full Changelog

Implemented enhancements:

  • feat: Add scripts for linting the config and fixed issues found #434 (susnux)
  • feat: Add sub config for TypeScript projects #433 (susnux)

Dependency updates:

... (truncated)

Commits
  • 6fb951e Merge pull request #644 from nextcloud-libraries/chore/prepare-8-3-0
  • fdebf56 chore: Prepare 8.3.0 release
  • 3e7d821 chore: Pin @vue/eslint-config-typescript to v12 to fix typescript issues fo...
  • 3bef196 Merge pull request #629 from nextcloud-libraries/dependabot/github_actions/ac...
  • 3f0e194 Merge pull request #635 from nextcloud-libraries/dependabot/npm_and_yarn/vue/...
  • 2feaafe Merge pull request #643 from nextcloud-libraries/dependabot/npm_and_yarn/esli...
  • cddc9bc build(deps-dev): Bump eslint-import-resolver-typescript
  • 6a1b2c0 Merge pull request #642 from nextcloud-libraries/dependabot/npm_and_yarn/esli...
  • 27e0f43 build(deps-dev): Bump eslint-plugin-jsdoc from 46.8.1 to 46.8.2
  • fad5b2d build(deps-dev): Bump @​vue/eslint-config-typescript
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review Waiting for reviews feature: dependencies Pull requests that update a dependency file labels Sep 30, 2023
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99f46a0) 1.81% compared to head (5bc382b) 2.07%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3639      +/-   ##
==========================================
+ Coverage     1.81%   2.07%   +0.26%     
==========================================
  Files          113      89      -24     
  Lines         6125    5347     -778     
  Branches      1491    1495       +4     
==========================================
  Hits           111     111              
+ Misses        5896    5118     -778     
  Partials       118     118              
Files Coverage Δ
src/components/AppNavigation/ContactsSettings.vue 0.00% <ø> (ø)
...nts/AppNavigation/Settings/SettingsAddressbook.vue 0.00% <ø> (ø)
src/components/EntityPicker/ContactsPicker.vue 0.00% <0.00%> (ø)
src/components/Properties/PropertyText.vue 0.00% <0.00%> (ø)
src/views/Contacts.vue 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nextcloud-command nextcloud-command left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 30, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@st3iny
Copy link
Member

st3iny commented Oct 17, 2023

@dependabot rebase

Bumps [@nextcloud/eslint-config](https://github.com/nextcloud-libraries/eslint-config) from 8.3.0-beta.2 to 8.3.0.
- [Release notes](https://github.com/nextcloud-libraries/eslint-config/releases)
- [Changelog](https://github.com/nextcloud-libraries/eslint-config/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/eslint-config@v8.3.0-beta.2...v8.3.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nextcloud/eslint-config-8.3.0 branch from e8c2f06 to de20d0e Compare October 17, 2023 12:48
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually fixed all linter errors. They were mostly unused parameters or avoid using any etc.

@st3iny st3iny enabled auto-merge October 17, 2023 12:52
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the dependabot/npm_and_yarn/nextcloud/eslint-config-8.3.0 branch from 5a4ef51 to 5bc382b Compare October 17, 2023 13:36
@st3iny st3iny merged commit b28e2e9 into main Oct 18, 2023
26 of 27 checks passed
@st3iny st3iny deleted the dependabot/npm_and_yarn/nextcloud/eslint-config-8.3.0 branch October 18, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants