fix: improve matching for tel type parameter #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3653 +/- ##
========================================
- Coverage 2.07% 2.07% -0.01%
========================================
Files 89 89
Lines 5348 5354 +6
Branches 1491 1492 +1
========================================
Hits 111 111
- Misses 5119 5125 +6
Partials 118 118
☔ View full report in Codecov by Sentry. |
The old implementation assigns the same score for HOME,VOICE and VOICE for a tel property with parameter voice. This pull requests adds an aditional point for the items with the same length. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/3651/update-matching-score
branch
from
439dbad to
503ae11
Compare
st3iny
approved these changes
Oct 11, 2023
st3iny
added
4. to release
|
/backport to stable5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3651, Close #3652
The old implementation assigns the same score for HOME,VOICE and VOICE for a tel property with parameter voice.
This pull requests adds an aditional point for the items with the same length.