Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundle moment.js locale data #3661

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 16, 2023

Fix #3657

Locales other than en were broken as they were not bundled. Only the default locale (en) is included by default with moment.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added bug Something isn't working 3. to review Waiting for reviews labels Oct 16, 2023
@st3iny st3iny added this to the v5.5.0 milestone Oct 16, 2023
@st3iny st3iny self-assigned this Oct 16, 2023
@st3iny
Copy link
Member Author

st3iny commented Oct 16, 2023

/backport to stable5.4

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c40864d) 1.80% compared to head (ace566f) 0.00%.

❗ Current head ace566f differs from pull request most recent head 9fb1d09. Consider uploading reports for the commit 9fb1d09 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3661      +/-   ##
==========================================
- Coverage     1.80%   0.00%   -1.81%     
  Complexity     260     260              
==========================================
  Files          113      24      -89     
  Lines         6136     782    -5354     
  Branches      1492       0    -1492     
==========================================
- Hits           111       0     -111     
+ Misses        5907     782    -5125     
+ Partials       118       0     -118     

see 89 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny enabled auto-merge October 16, 2023 14:44
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 16, 2023
@st3iny st3iny merged commit 9ed4a15 into main Oct 16, 2023
25 checks passed
@st3iny st3iny deleted the fix/bundle-moment-locale-data branch October 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last modified relative date is not localized correctly
2 participants