Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix prod build after updating babel/preset-env #3688

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 2, 2023

Fix #3747

This PR is outdated on purpose as well to reproduce the production build failure.

This is a bit hacky but the app builds again 🙈

@st3iny st3iny requested a review from ChristophWurst November 2, 2023 09:42
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72b0ea3) 2.13% compared to head (050919b) 2.07%.

❗ Current head 050919b differs from pull request most recent head 83d37ef. Consider uploading reports for the commit 83d37ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3688      +/-   ##
==========================================
- Coverage     2.13%   2.07%   -0.07%     
==========================================
  Files          113      89      -24     
  Lines         5191    5358     +167     
  Branches      1125    1498     +373     
==========================================
  Hits           111     111              
- Misses        4960    5127     +167     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member Author

st3iny commented Dec 18, 2023

Dev build fails now too on my machine.

@st3iny st3iny self-assigned this Dec 18, 2023
@st3iny st3iny added the 3. to review Waiting for reviews label Dec 18, 2023
@st3iny st3iny marked this pull request as ready for review December 18, 2023 19:11
@st3iny st3iny merged commit 6c77c13 into main Dec 18, 2023
27 checks passed
@st3iny st3iny deleted the fix/prod-build branch December 18, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building only with npm run watch and circles installed
3 participants