Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove import contact button from chart view #3751

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Remove import contact button from chart view #3751

merged 1 commit into from
Dec 20, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Dec 20, 2023 •
edited
Loading

fix #3750

Before After
image image

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Dec 20, 2023
@hamza221 hamza221 requested a review from GretaD December 20, 2023 14:59
@hamza221 hamza221 self-assigned this Dec 20, 2023
@hamza221 hamza221 requested a review from GVodyanov December 20, 2023 15:01
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6c77c13) 2.51% compared to head (f9999aa) 2.51%.

Files Patch % Lines
src/views/Contacts.vue 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #3751      +/-   ##
========================================
- Coverage   2.51%   2.51%   -0.01%     
========================================
  Files         89      89              
  Lines       4407    4409       +2     
  Branches    1125    1125              
========================================
  Hits         111     111              
- Misses      4176    4178       +2     
  Partials     120     120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221 hamza221 merged commit d88ea9a into main Dec 20, 2023
26 of 28 checks passed
@hamza221 hamza221 deleted the Fix/remove-import-contact branch December 20, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Organization chart" shows "Import contacts" button on top of navigation
2 participants
@hamza221 @GretaD