Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/Enhance group information display #3752

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Enh/Enhance group information display #3752

merged 1 commit into from
Apr 15, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #3706

Before After
image image

@GVodyanov GVodyanov linked an issue Dec 20, 2023 that may be closed by this pull request
Visibility of Contact Groups is broken in Detail View #3706
Closed
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 2.51%. Comparing base (8c3a4f5) to head (9da6986).
Report is 17 commits behind head on main.

❗ Current head 9da6986 differs from pull request most recent head 0966750. Consider uploading reports for the commit 0966750 to get more accurate results

Files Patch % Lines
src/components/Properties/PropertyGroups.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #3752      +/-   ##
========================================
+ Coverage   2.44%   2.51%   +0.07%     
========================================
  Files         90      89       -1     
  Lines       4541    4414     -127     
  Branches    1163    1128      -35     
========================================
  Hits         111     111              
+ Misses      4310    4183     -127     
  Partials     120     120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor

hamza221 commented Apr 2, 2024

@GVodyanov can you please check failing CI ^^

@hamza221 hamza221 mentioned this pull request Apr 5, 2024
Merged
@hamza221
Copy link
Contributor

hamza221 commented Apr 11, 2024 •
edited
Loading

@GVodyanov friendly ping , npm run lint:fix , squash , rebase

@GVodyanov
Copy link
Contributor Author

GVodyanov commented Apr 11, 2024 •
edited
Loading

Sorry here I am, btw during testing I found this #3880, looks pretty bad @hamza221

Nvm Christoph left an explanation

@GVodyanov GVodyanov force-pushed the Enh/Enhance-group-information branch from 0d65171 to 9a7a406 Compare April 11, 2024 16:48
@GVodyanov
Enh/Enhance group information display
0966750 
Signed-off-by: Grigory V <[email protected]>

Fix/avoid empty div

Co-authored-by: Hamza <[email protected]>
Signed-off-by: Grigory V <[email protected]>

Fix lint complaints

Signed-off-by: Grigory Vodyanov <[email protected]>

Enh/Enhance group information display
@GVodyanov GVodyanov force-pushed the Enh/Enhance-group-information branch from 9a7a406 to 0966750 Compare April 11, 2024 16:54
@GVodyanov GVodyanov requested a review from hamza221 April 11, 2024 17:16
@hamza221
Copy link
Contributor

@ChristophWurst Is this the desired UI?

@ChristophWurst
Copy link
Member

Seems find if I look at the screenshots of #3706

@GVodyanov GVodyanov merged commit 0c91ff4 into main Apr 15, 2024
19 checks passed
@GVodyanov GVodyanov deleted the Enh/Enhance-group-information branch April 15, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visibility of Contact Groups is broken in Detail View
3 participants
@GVodyanov @hamza221 @ChristophWurst