Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: extra primary elements #3753

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Dec 20, 2023

Fix #3739
Any other elements need fixing?

Before After
image image

For context this is what it looked like pre nc/vue 8
image

Signed-off-by: hamza mahjoubi <[email protected]>
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Dec 20, 2023
@hamza221 hamza221 self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d88ea9a) 2.51% compared to head (4aead8e) 2.51%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3753   +/-   ##
=====================================
  Coverage   2.51%   2.51%           
=====================================
  Files         89      89           
  Lines       4409    4409           
  Branches    1125    1125           
=====================================
  Hits         111     111           
  Misses      4178    4178           
  Partials     120     120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a first step – @nextcloud/designers we need to check for 3-column layouts how we can improve that there will be 2 primary "current" elements highlighted.

@hamza221 hamza221 merged commit 7c7d02e into main Dec 21, 2023
28 checks passed
@hamza221 hamza221 deleted the Fix/remove-extra-primary-elements branch December 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

design: too many primary elements since NC-vue 8?
2 participants