Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Contact subtitle encoding #3755

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix/Contact subtitle encoding #3755

merged 1 commit into from
Dec 27, 2023

Conversation

GVodyanov
Copy link
Contributor

Fix #3720

@GVodyanov GVodyanov requested a review from GretaD December 23, 2023 14:46
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f8fac8) 2.13% compared to head (7a830aa) 2.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3755      +/-   ##
==========================================
+ Coverage     2.13%   2.51%   +0.38%     
==========================================
  Files          113      89      -24     
  Lines         5193    4409     -784     
  Branches      1125    1125              
==========================================
  Hits           111     111              
+ Misses        4962    4178     -784     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works :)

@GretaD GretaD merged commit 554b03a into main Dec 27, 2023
28 checks passed
@GretaD GretaD deleted the Fix/contact-subtitle-encoding branch December 27, 2023 11:12
Copy link

welcome bot commented Dec 27, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@GretaD
Copy link
Contributor

GretaD commented Dec 27, 2023

do we need a backport here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double HTML encoding in compound representation of contact's Title and Company
2 participants