Add confirmation dialog before importing contacts #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3759 +/- ##
==========================================
- Coverage 2.51% 0.00% -2.52%
- Complexity 0 261 +261
==========================================
Files 89 24 -65
Lines 4411 784 -3627
Branches 1126 0 -1126
==========================================
- Hits 111 0 -111
+ Misses 4180 784 -3396
+ Partials 120 0 -120 ☔ View full report in Codecov by Sentry. |
GretaD
force-pushed
the
feat/add-confirmation-dialog
branch
from
13ec9db to
858be11
Compare
st3iny
reviewed
Jan 30, 2024
GretaD
added
3. to review
st3iny
approved these changes
Jan 30, 2024
Signed-off-by: greta <[email protected]>
GretaD
force-pushed
the
feat/add-confirmation-dialog
branch
from
caf7218 to
3e3fcd8
Compare
| // Redirect to the import page if the user confirmed | ||
| window.location = generateUrl(`/apps/contacts/import?file=${file.path}`) | ||
| } catch (e) { | ||
| // Do nothing if the user cancels |
There was a problem hiding this comment.
logging would be advisable here if anything but rejection is thrown
There was a problem hiding this comment.
i can do that with a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2788