Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty content when at least one related resrouce exists. #3760

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Dec 29, 2023

fixes #3758

while debugging, i realized that each panel updates the hasRelatedResources flag independently, which leads to an incorrect state if any panel sets it to true and then another sets it to false.

This fixup makes sure that hasRelatedResources becomes true if any of the panels have resources and remains true once it is set.

@GretaD GretaD added bug Something isn't working 3. to review Waiting for reviews labels Dec 29, 2023
@GretaD GretaD self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (554b03a) 2.51% compared to head (45c7d93) 2.51%.
Report is 9 commits behind head on main.

Files Patch % Lines
src/components/ContactDetails.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3760      +/-   ##
========================================
- Coverage   2.51%   2.51%   -0.01%     
========================================
  Files         89      89              
  Lines       4409    4411       +2     
  Branches    1125    1126       +1     
========================================
  Hits         111     111              
- Misses      4178    4180       +2     
  Partials     120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD requested review from JohannesGGE and removed request for GVodyanov January 2, 2024 17:39
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 3, 2024
@st3iny st3iny modified the milestones: v5.5.0, v5.6.0 Jan 3, 2024
@st3iny st3iny merged commit a5bede1 into main Jan 3, 2024
26 of 28 checks passed
@st3iny st3iny deleted the fix/empty-content-resources branch January 3, 2024 10:09
@st3iny
Copy link
Member

st3iny commented Jan 3, 2024

/backport to stable5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty content shown even tho there's content on contact details
3 participants