Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vue3): migrate event buses to mitt #3766

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 2, 2024

@st3iny st3iny added 3. to review Waiting for reviews technical debt labels Jan 2, 2024
@st3iny st3iny self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ebe8c80) 2.13% compared to head (045ede5) 2.51%.

Files Patch % Lines
src/components/ContactsList/ContactsListItem.vue 0.00% 4 Missing ⚠️
src/components/ContactDetails.vue 0.00% 1 Missing ⚠️
...onents/ContactDetails/ContactDetailsAddNewProp.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main   #3766      +/-   ##
==========================================
+ Coverage     2.13%   2.51%   +0.38%     
==========================================
  Files          113      89      -24     
  Lines         5193    4409     -784     
  Branches      1125    1125              
==========================================
  Hits           111     111              
+ Misses        4962    4178     -784     
  Partials       120     120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst ChristophWurst merged commit 0195719 into main Jan 3, 2024
27 of 28 checks passed
@ChristophWurst ChristophWurst deleted the chore/vue3/migrate-event-buses-to-mitt branch January 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants