Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: responsiveness for contacts details #4045

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: responsiveness for contacts details #4045

merged 1 commit into from
Jul 23, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 23, 2024 •
edited
Loading

fix #4022

b a
image image

@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Jul 23, 2024
@hamza221 hamza221 requested review from st3iny, GretaD and GVodyanov July 23, 2024 11:52
@hamza221 hamza221 self-assigned this Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (4096c68) to head (d2b8749).

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4045   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221 hamza221 force-pushed the fix/responsiveness branch from 7f74dbe to d2b8749 Compare July 23, 2024 12:12
@hamza221 hamza221 requested a review from GVodyanov July 23, 2024 12:13
GVodyanov
GVodyanov previously requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I don't like how the name is running away from the avatar icon here

@hamza221 hamza221 force-pushed the fix/responsiveness branch from d2b8749 to 71d3bc9 Compare July 23, 2024 12:54
@hamza221 hamza221 requested a review from GVodyanov July 23, 2024 12:54
st3iny
st3iny approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny dismissed GVodyanov’s stale review July 23, 2024 14:22

Has been delivered.

@st3iny st3iny merged commit 3b5fc98 into main Jul 23, 2024
24 checks passed
@st3iny st3iny deleted the fix/responsiveness branch July 23, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov is a code owner

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contact details heavily misaligned on small/mobile screens
4 participants
@hamza221 @AndyScherzinger @st3iny @GVodyanov