Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for RFC 6474 #4173

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: support for RFC 6474 #4173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/models/rfcProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ const properties = {
],
primary: true,
},
birthplace: {
readableName: t('contacts', 'Place of birth'),
icon: 'icon-location',
force: 'text',
primary: false,
},
anniversary: {
readableName: t('contacts', 'Anniversary'),
icon: 'icon-anniversary',
Expand All @@ -153,6 +159,12 @@ const properties = {
},
primary: false,
},
deathplace: {
readableName: t('contacts', 'Place of death'),
icon: 'icon-location',
force: 'text',
Copy link
Contributor

@hamza221 hamza221 Oct 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can also be a URI, I'm not sure if 'text' would break anything

primary: false,
},
email: {
multiple: true,
readableName: t('contacts', 'Email'),
Expand Down Expand Up @@ -396,8 +408,10 @@ const fieldOrder = [
'x-managersname',

// secondary fields
'birthplace',
'anniversary',
'deathdate',
'deathplace',
'n',
'nickname',
'x-phonetic-first-name',
Expand Down
Loading