-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a read-only contactdetails component #4194
Conversation
@st3iny its still a draft, but if you already have comments, please let me know :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4194 +/- ##
=============================================
- Coverage 66.20% 11.37% -54.83%
- Complexity 262 265 +3
=============================================
Files 25 121 +96
Lines 787 5556 +4769
Branches 0 1196 +1196
=============================================
+ Hits 521 632 +111
- Misses 266 4802 +4536
- Partials 0 122 +122 ☔ View full report in Codecov by Sentry. |
Hey! How do I review this? Is it the section in the composer? |
you can check the code if you want, but the data you see on mail composer from the recipient, comes from here :) |
I noticed that the report request always returns all cards instead of only the ones matching the filter. This seems to be caused by an issue with the XML request body, which is incorrect. Wrong: <x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
<x0:prop xmlns:x0="DAV:">
... removed for better readability
</x0:prop>
<x4:filter test="anyof">
<x4:prop-filter name="EMAIL">
<x1:text-match xmlns:x1="urn:ietf:params:xml:ns:caldav">
[email protected]
</x1:text-match>
</x4:prop-filter>
</x4:filter>
</x4:addressbook-query> Correct: <x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
<x0:prop xmlns:x0="DAV:">
... removed for better readability
</x0:prop>
<x4:filter test="anyof">
<x4:prop-filter name="EMAIL">
<x4:text-match>[email protected]</x4:text-match>
</x4:prop-filter>
</x4:filter>
</x4:addressbook-query> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Works. See comments on the reference PR in description
c50ca7b
to
e25da15
Compare
Signed-off-by: greta <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]>
e25da15
to
b5458b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! |
this will be the readonly component to be used on contacts and mail
this change is required for ref: nextcloud/mail#9622