fix: remove unused style #4244
Merged
fix: remove unused style #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Git'Fellow <[email protected]>
solracsf
requested review from
hamza221 and
SebastianKrupinski
as code owners
|
Tested Works. Before: After: |
SebastianKrupinski
approved these changes
Dec 5, 2024
|
Thanks. I'm not familiar with backports policy in this repo but please consider backporting it 👍🏻 |
|
We normally try to back port fixes 3 versions for all repos, for the contacts app that would be 6.1, 6.0, 5.5. The only issue is that with the constructor changes, back porting this fix is not possible, version 6.0 supports a min php version of 7.4 which does not support the constructor variable declarations. Also the removal of the addInitScript check makes pack porting to 6.0 impossible as 6.0 supports a min Nc version of 27. So long story short we can't really back port these changes. Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4148