persist credentials retrieved through the wizard #7768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AppImage file: nextcloud-PR-7768-34c51cc616f899ca3a4c586cc506f41f7acb3ce1-x86_64.AppImage |
mgallien
approved these changes
Jan 24, 2025
When setting up an account through the wizard for the first time, the credentials are not saved properly. This requires the user to sign in again after an application restart. At least for the login flow v2 case, the `WebFlowCredentials` class eventually persists the retrieved credentials, whereas the class used within the wizard (`OCC::Flow2AuthCredsPage`) doesn't. Signed-off-by: Jyrki Gadinger <[email protected]>
mgallien
force-pushed
the
bugfix/relogin-after-initial-setup-wizard
branch
from
34c51cc to
75fdfea
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7768.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up an account through the wizard for the first time, the credentials are not saved properly. This requires the user to sign in again after an application restart.
At least for the login flow v2 case, the
WebFlowCredentialsclass eventually persists the retrieved credentials, whereas the class used within the wizard (OCC::Flow2AuthCredsPage) doesn't.