Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - ignore for now: refactor(admin): Trash bin configuration chapter (WIP - ignore for now) #12432

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

☑️ Resolves

  • Fix #…

TODO

  • Review Admin - Configuration: Deleted Files chapter
  • Review Admin - Configuration: config.php sample chapter
  • Review User - Files: Deleted Items chapter
  • Initial code review
  • Initial pass an updating above chapter [incomplete]
  • Review other areas of code that may land here and just overall review the code again
  • Review the old "50%" references in log messages that based on code review so far don't even seem applicable...
  • Check potentially relevant open bugs in server
    • Consider fixing them first, if applicable and/or updating the documentation to match implementation + close bug report(s)
  • Update Admin - Configuration: Deleted Files chapter
    • Introduction
    • Default policy
    • Specifying a global trash bin size (or a per account one) via occ trashbin:size
    • Policy interaction with quotas
    • Customizing your policy via trashbin_retention_obligation
    • Background jobs - standard
    • Background jobs -
  • Update Admin - Configuration: config.php sample chapter section
    • Note: in server
    • Initial observations: Lots of duplicated stuff here that should just move to the actual chapter on the topic
  • Update User - Files: Deleted Items chapter
    • Initial observations: Contains admin-level config references; these bits should be removed/moved to the admin manual
  • Test test test
  • Review all counterpart chapters/sections in Admin and User manuals for files_versions as well as applicable code (but do in a separate follow-on branch/PR)
  • Review review review

🖼️ Screenshots

@joshtrichards joshtrichards self-assigned this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant