-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be clear that ES7 is no longer supported #272
Conversation
Yes, but ES7 should still works with nc26. |
Interesting, I actually landed here because fulltext search stopped working after upgrading to NC 27. |
I was having issues when trying to use app version >= 26 (which is using ES client 8) together with ES 7.x. Btw: it highly depends on which exact server version you're using. For example with older versions of ES 7, the newer ES 8 client (which is included in app versions >= 26) is not compatible. Here an example when running ES 7.6.0:
<?php
require_once 'vendor/autoload.php';
$client = Elastic\Elasticsearch\ClientBuilder::create()
->setHosts(['http://localhost:9200'])
->build();
$info = $response = $client->info();
echo($info);
You will see the following error:
which is produced because ES 7.6.0 does not set an expected header in the response (see also here). So this is just one sample where client and server are not compatible and I'm sure there are many more 😄 |
So, if I use my elasticsearch 7.17.13, it explains why I can't find nothing with my Nextcloud 26.0.7 ? If yes, it should be cool to avoid a bit more.. I broke my prod because of that. |
Well.. it depends 😄 It could be the cause of the error but I'd recommend: lower your loglevel, reproduce your problem and inspect the server logs. Maybe it will show you what went wrong. I definitely agree. To me it would make sense to add a setupcheck for this or at least have some |
Could it be related ? occ fulltextsearch:test .Testing your current setup:
Unexpected SearchResult: {"provider":{"id":"test_provider","name":"Test Provider"},"platform":{"id":"elastic_search","name":"Elasticsearch"},"documents":[],"info":[],"meta":{"timedOut":false,"ti fulltextsearch:test [--output [OUTPUT]] [-j|--json] [-d|--platform_delay PLATFORM_DELAY] |
I saw this error recently. Maybe our conversation from #237 (comment) will help you. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
The current docs are misleading. I broke my NC install because there was no indication that ES7 is no longer supported.
Hopefully this will protect another admin out there.
Source: #269 (comment)