Add 'direct' GET param to invite email 'view share' link #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
julien-nc
requested review from
nickvergessen,
icewind1991,
artonge and
skjnldsv
julien-nc
force-pushed
the
enh/noid/view-share-direct-link
branch
from
bd6bf19 to
6a2cbc9
Compare
|
@blizzz i only know the direct from saml, any chance this conflicts/creates an issue? |
No, this should be all fine. |
|
@blizzz Thanks Static analysis failure is due to a new method recently added in |
…uests can login when SSO is enabled (with user_saml, user_oidc...) Signed-off-by: Julien Veyssier <[email protected]>
solracsf
force-pushed
the
enh/noid/view-share-direct-link
branch
from
6a2cbc9 to
60e004c
Compare
|
All green now 🟢 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user_saml or user_oidc are configured to automatically redirect the login page to an IdP, guests can't authenticate when clicking the link included in the share/invite email.
Adding the
direct=1GET param to the/f/FILE_IDlink works because the GET param is preserved when being redirected to the login page.Should this be optional? I think it's fine to always have it since we know we want a direct login for guests.
Wdyt?