Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding image.flavor to values.yaml and clarifying image.tag in README configuration table #438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 4.4.0
version: 4.4.1
appVersion: 27.1.3
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
4 changes: 3 additions & 1 deletion charts/nextcloud/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ The following table lists the configurable parameters of the nextcloud chart and
|------------------------------------------------------------|----------------------------------------------------------------------------------------------|----------------------------|
| `image.repository` | nextcloud Image name | `nextcloud` |
| `image.flavor` | nextcloud Image type (Options: apache, fpm) | `apache` |
| `image.tag` | nextcloud Image tag | `appVersion` |
| `image.tag` | nextcloud Image tag | [`appVersion`] |
| `image.pullPolicy` | Image pull policy | `IfNotPresent` |
| `image.pullSecrets` | Specify image pull secrets | `nil` |
| `replicaCount` | Number of nextcloud pods to deploy | `1` |
Expand Down Expand Up @@ -485,3 +485,5 @@ After an upgrade, you may have missing indices. To fix this, you can run:
# where NEXTCLOUD_POD is *your* nextcloud pod
kubectl exec -it $NEXTCLOUD_POD -- su -s /bin/sh www-data -c "php occ db:add-missing-indices"
```

[`appVersion`]: https://github.com/nextcloud/helm/blob/main/charts/nextcloud/Chart.yaml#L4 "appVersion on line 4 of Chart.yaml"
5 changes: 4 additions & 1 deletion charts/nextcloud/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
##
image:
repository: nextcloud
# tag: 24.0.3-apache
# tag defaults to appVersion in Chart.yaml
tag: ""
# flavor can be either fpm or apache. Set to fpm if using nginx
flavor: ""
pullPolicy: IfNotPresent
# pullSecrets:
# - myRegistrKeySecretName
Expand Down