-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Collabora as a subchart #611 #623
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: kriegalex <[email protected]>
Signed-off-by: kriegalex <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
Oh, awesome! Thanks, @kriegalex for this PR! Right now the workflow is failing: You can fix this by adding the helm repo for collabora to this section of the workflow file, similar to how we do for bitnami: helm/.github/workflows/lint-test.yaml Lines 39 to 41 in b25b4ad
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, but we need to ensure the tests still work, so I left a comment about how to update the GHA workflow. If you can, it would also be neat to have a test for collabora itself as well, but we can also hold off on that for a separate PR if you'd like. 🙏
update: added the commit to maybe fix the tests :)
…testing Signed-off-by: Jesse Hitch <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
Thanks for the change on lint tests. I'm still learning k8s, didn't think of that. |
Signed-off-by: kriegalex <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
Description of the change
Benefits
Possible drawbacks
extra_params
,server_name
,aliasgroups
andannotations
.Applicable issues
Additional information
Tested on my local kubernetes cluster with a HTTPS nginx ingress. Nextcloud can communicate with Collabora. Not tested with HAProxy (though it is only a change in annotations specific to HAProxy).
Checklist
Chart.yaml
according to semver.