Auto upload from specific Albums

[mpivchev]

This adds the ability to select which album(s) to auto upload.

• If no album is chosen, Camera Roll is chosen by default.
• Works on a multi-account setup
• Redesigned some parts of the auto upload screen, and added a proper button that is the focus point of all the settings.

[i2h3]

I have not tested it functionally yet.

[i2h3]

Isn't there a common reusable SwiftUI view for this kind of button or is this here a unique appearance?

[mpivchev]

I don't think there is a predefined component for this, it's a toggle that looks like a button.

[i2h3]

No, I meant within our own code in the project. Don't we have similar buttons elsewhere?

[mpivchev]

@i2h3 Did you manage to check functionality?

[i2h3]

@i2h3 Did you manage to check functionality?

I wanted to wait for the code changes first. Now I am stuck in a lot of other tasks of higher priority.

[i2h3]

Layout Improvements Needed

Screenshots taken on iPad 11" in landscape orientation.

Automatic Uploads

• The scrollable content does not have any padding to the navigation bar.

Album Selection

• The scrollable content does not have any padding to the navigation bar.
• The navigation title is not utilized.

[i2h3]

Settings Not Reenabled After Uploads Completed

I waited for the automatic uploads of my favorites album to complete. The settings controls are not reenabled after completion. I wanted to also enable automatic upload of videos which I cannot. Navigating back and forth in the settings or selecting different tabs in the app does not help.

I first need to tap the stop button for the automatic uploading. That was not clear to me.

The German footer of the button "Obenstehende Optionen vor dem Hochladen anpassen." does not make much sense to me. The English reference is "Adjust the options above before uploading.". Either the translators need more context or the string needs to be more expressive.

I am a bit irritated by the necessity of manually starting and stopping the automatic upload which then I would not consider fully automated anymore. I would have assumed the upload actually is already enabled by the switch on the top.